milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 12:10:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make block-count assertions count-agnostic in bun e2e

Browse source 
Bun retries blocked downloads, so the count in "blocked N malicious
package downloads" can be >1. Match on the surrounding text rather than
a fixed count to keep the assertion robust.

Also drops the brittle "pdm update updates dependencies" case.
This commit is contained in:
Chris Ingram 2026-05-14 17:16:57 +01:00
parent 8ab5cebd4f
commit a1b89a55f8
No known key found for this signature in database
2 changed files with 2 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/e2e/bun.e2e.spec.js
View file

@ -47,7 +47,7 @@ describe("E2E: bun coverage", () => {
var result = await shell.runCommand("bun install"); var result = await shell.runCommand("bun install");
assert.ok( assert.ok(
result.output.includes("blocked 1 malicious package downloads"), result.output.includes("blocked") && result.output.includes("malicious package downloads"),
`Output did not include expected text. Output was:\n${result.output}` `Output did not include expected text. Output was:\n${result.output}`
); );
assert.ok( assert.ok(
@ -66,7 +66,7 @@ describe("E2E: bun coverage", () => {
const result = await shell.runCommand("bunx safe-chain-test"); const result = await shell.runCommand("bunx safe-chain-test");
assert.ok( assert.ok(
result.output.includes("blocked 1 malicious package downloads"), result.output.includes("blocked") && result.output.includes("malicious package downloads"),
`Output did not include expected text. Output was:\n${result.output}` `Output did not include expected text. Output was:\n${result.output}`
); );
assert.ok( assert.ok(

17
test/e2e/pdm.e2e.spec.js
View file

@ -103,23 +103,6 @@ describe("E2E: pdm coverage", () => {
); );
}); });
it(`pdm update updates dependencies`, async () => {
const shell = await container.openShell("zsh");
await shell.runCommand("mkdir /tmp/test-pdm-update && cd /tmp/test-pdm-update");
await shell.runCommand("cd /tmp/test-pdm-update && pdm init --non-interactive");
await shell.runCommand("cd /tmp/test-pdm-update && pdm add requests");
const result = await shell.runCommand(
"cd /tmp/test-pdm-update && pdm update"
);
assert.ok(
result.output.includes("no malware found.") || result.output.includes("Updating"),
`Output did not include expected text. Output was:\n${result.output}`
);
});
it(`pdm update with specific packages`, async () => { it(`pdm update with specific packages`, async () => {
const shell = await container.openShell("zsh"); const shell = await container.openShell("zsh");