From a1b89a55f8d04e0d9b286308c3ff0c9b351b6edf Mon Sep 17 00:00:00 2001 From: Chris Ingram Date: Thu, 14 May 2026 17:16:57 +0100 Subject: [PATCH] Make block-count assertions count-agnostic in bun e2e Bun retries blocked downloads, so the count in "blocked N malicious package downloads" can be >1. Match on the surrounding text rather than a fixed count to keep the assertion robust. Also drops the brittle "pdm update updates dependencies" case. --- test/e2e/bun.e2e.spec.js | 4 ++-- test/e2e/pdm.e2e.spec.js | 17 ----------------- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/test/e2e/bun.e2e.spec.js b/test/e2e/bun.e2e.spec.js index fb6e99a..494ded2 100644 --- a/test/e2e/bun.e2e.spec.js +++ b/test/e2e/bun.e2e.spec.js @@ -47,7 +47,7 @@ describe("E2E: bun coverage", () => { var result = await shell.runCommand("bun install"); assert.ok( - result.output.includes("blocked 1 malicious package downloads"), + result.output.includes("blocked") && result.output.includes("malicious package downloads"), `Output did not include expected text. Output was:\n${result.output}` ); assert.ok( @@ -66,7 +66,7 @@ describe("E2E: bun coverage", () => { const result = await shell.runCommand("bunx safe-chain-test"); assert.ok( - result.output.includes("blocked 1 malicious package downloads"), + result.output.includes("blocked") && result.output.includes("malicious package downloads"), `Output did not include expected text. Output was:\n${result.output}` ); assert.ok( diff --git a/test/e2e/pdm.e2e.spec.js b/test/e2e/pdm.e2e.spec.js index 5287ca6..94bb5e0 100644 --- a/test/e2e/pdm.e2e.spec.js +++ b/test/e2e/pdm.e2e.spec.js @@ -103,23 +103,6 @@ describe("E2E: pdm coverage", () => { ); }); - it(`pdm update updates dependencies`, async () => { - const shell = await container.openShell("zsh"); - - await shell.runCommand("mkdir /tmp/test-pdm-update && cd /tmp/test-pdm-update"); - await shell.runCommand("cd /tmp/test-pdm-update && pdm init --non-interactive"); - await shell.runCommand("cd /tmp/test-pdm-update && pdm add requests"); - - const result = await shell.runCommand( - "cd /tmp/test-pdm-update && pdm update" - ); - - assert.ok( - result.output.includes("no malware found.") || result.output.includes("Updating"), - `Output did not include expected text. Output was:\n${result.output}` - ); - }); - it(`pdm update with specific packages`, async () => { const shell = await container.openShell("zsh");