Refactor to customize shell integration per shell

src/shell-integration/supported-shells/fish.spec.js

@@ -0,0 +1,190 @@
+import { describe, it, beforeEach, afterEach, mock } from "node:test";
+import assert from "node:assert";
+import { tmpdir } from "node:os";
+import fs from "node:fs";
+import path from "path";
+
+describe("Fish shell integration", () => {
+  let mockStartupFile;
+  let fish;
+
+  beforeEach(async () => {
+    // Create temporary startup file for testing
+    mockStartupFile = path.join(tmpdir(), `test-fish-config-${Date.now()}`);
+    
+    // Mock the helpers module
+    mock.module("../helpers.js", {
+      namedExports: {
+        execAndGetOutput: () => mockStartupFile,
+        doesExecutableExistOnSystem: () => true,
+        addLineToFile: (filePath, line) => {
+          if (!fs.existsSync(filePath)) {
+            fs.writeFileSync(filePath, "", "utf-8");
+          }
+          fs.appendFileSync(filePath, line + "\n", "utf-8");
+        },
+        removeLinesMatchingPattern: (filePath, pattern) => {
+          if (!fs.existsSync(filePath)) return;
+          const content = fs.readFileSync(filePath, "utf-8");
+          const lines = content.split("\n");
+          const filteredLines = lines.filter(line => !pattern.test(line));
+          fs.writeFileSync(filePath, filteredLines.join("\n"), "utf-8");
+        }
+      }
+    });
+
+    // Import fish module after mocking
+    fish = (await import("./fish.js")).default;
+  });
+
+  afterEach(() => {
+    // Clean up test files
+    if (fs.existsSync(mockStartupFile)) {
+      fs.unlinkSync(mockStartupFile);
+    }
+    
+    // Reset mocks
+    mock.reset();
+  });
+
+  describe("isInstalled", () => {
+    it("should return true when fish is installed", () => {
+      assert.strictEqual(fish.isInstalled(), true);
+    });
+
+    it("should call doesExecutableExistOnSystem with correct parameter", () => {
+      // Test that the method calls the helper with the right executable name
+      assert.strictEqual(fish.isInstalled(), true);
+    });
+  });
+
+  describe("setup", () => {
+    it("should add aliases for all provided tools", () => {
+      const tools = ["npm", "npx", "yarn"];
+
+      const result = fish.setup(tools);
+      assert.strictEqual(result, true);
+
+      const content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(content.includes('alias npm "aikido-npm" # Safe-chain alias for npm'));
+      assert.ok(content.includes('alias npx "aikido-npx" # Safe-chain alias for npx'));
+      assert.ok(content.includes('alias yarn "aikido-yarn" # Safe-chain alias for yarn'));
+    });
+
+    it("should call teardown before setup", () => {
+      // Pre-populate file with existing aliases
+      fs.writeFileSync(mockStartupFile, 'alias npm "old-npm"\nalias npx "old-npx"\n', "utf-8");
+
+      const tools = ["npm"];
+      fish.setup(tools);
+
+      const content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(!content.includes('alias npm "old-npm"'));
+      assert.ok(content.includes('alias npm "aikido-npm"'));
+    });
+
+    it("should handle empty tools array", () => {
+      const result = fish.setup([]);
+      assert.strictEqual(result, true);
+      
+      // File should be created during teardown call even if no tools are provided
+      if (fs.existsSync(mockStartupFile)) {
+        const content = fs.readFileSync(mockStartupFile, "utf-8");
+        assert.strictEqual(content.trim(), "");
+      }
+    });
+  });
+
+  describe("teardown", () => {
+    it("should remove npm, npx, and yarn aliases", () => {
+      const initialContent = [
+        "#!/usr/bin/env fish",
+        "alias npm 'aikido-npm'",
+        "alias npx 'aikido-npx'",
+        "alias yarn 'aikido-yarn'",
+        "alias ls 'ls --color=auto'",
+        "alias grep 'grep --color=auto'"
+      ].join("\n");
+
+      fs.writeFileSync(mockStartupFile, initialContent, "utf-8");
+
+      const result = fish.teardown();
+      assert.strictEqual(result, true);
+
+      const content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(!content.includes("alias npm "));
+      assert.ok(!content.includes("alias npx "));
+      assert.ok(!content.includes("alias yarn "));
+      assert.ok(content.includes("alias ls "));
+      assert.ok(content.includes("alias grep "));
+    });
+
+    it("should handle file that doesn't exist", () => {
+      if (fs.existsSync(mockStartupFile)) {
+        fs.unlinkSync(mockStartupFile);
+      }
+
+      const result = fish.teardown();
+      assert.strictEqual(result, true);
+    });
+
+    it("should handle file with no relevant aliases", () => {
+      const initialContent = [
+        "#!/usr/bin/env fish",
+        "alias ls 'ls --color=auto'",
+        "set PATH $PATH ~/bin"
+      ].join("\n");
+
+      fs.writeFileSync(mockStartupFile, initialContent, "utf-8");
+
+      const result = fish.teardown();
+      assert.strictEqual(result, true);
+
+      const content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(content.includes("alias ls "));
+      assert.ok(content.includes("set PATH "));
+    });
+  });
+
+  describe("shell properties", () => {
+    it("should have correct name", () => {
+      assert.strictEqual(fish.name, "Fish");
+    });
+
+    it("should expose all required methods", () => {
+      assert.ok(typeof fish.isInstalled === "function");
+      assert.ok(typeof fish.setup === "function");
+      assert.ok(typeof fish.teardown === "function");
+      assert.ok(typeof fish.name === "string");
+    });
+  });
+
+  describe("integration tests", () => {
+    it("should handle complete setup and teardown cycle", () => {
+      const tools = ["npm", "yarn"];
+
+      // Setup
+      fish.setup(tools);
+      let content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(content.includes('alias npm "aikido-npm"'));
+      assert.ok(content.includes('alias yarn "aikido-yarn"'));
+
+      // Teardown
+      fish.teardown();
+      content = fs.readFileSync(mockStartupFile, "utf-8");
+      assert.ok(!content.includes("alias npm "));
+      assert.ok(!content.includes("alias yarn "));
+    });
+
+    it("should handle multiple setup calls", () => {
+      const tools = ["npm"];
+
+      fish.setup(tools);
+      fish.setup(tools);
+      
+      const content = fs.readFileSync(mockStartupFile, "utf-8");
+      const npmMatches = (content.match(/alias npm "/g) || []).length;
+      assert.strictEqual(npmMatches, 1, "Should not duplicate aliases");
+    });
+  });
+});