Merge pull request #22 from AikidoSec/scoped-packages

Fix undefined error when adding scoped package on yarn, npm or npx

src/packagemanager/npm/parsing/parsePackagesFromInstallArgs.js

@@ -86,7 +86,9 @@ function parsePackagename(arg) {
   const lastAtIndex = arg.lastIndexOf("@");
 
   let name, version;
-  if (lastAtIndex !== -1) {
+  // The index of the last "@" should be greater than 0
+  // If the index is 0, it means the package name starts with "@" (eg: "@vercel/otel")
+  if (lastAtIndex > 0) {
     name = arg.slice(0, lastAtIndex);
     version = arg.slice(lastAtIndex + 1);
   } else {

src/packagemanager/npm/parsing/parsePackagesFromInstallArgs.spec.js

@@ -19,6 +19,14 @@ describe("parsePackagesFromInstallArgs", () => {
     assert.deepEqual(result, [{ name: "@jest/transform", version: "29.7.0" }]);
   });
 
+  it("should return the package in the format @vercel/otel", () => {
+    const args = ["install", "@vercel/otel"];
+
+    const result = parsePackagesFromInstallArgs(args);
+
+    assert.deepEqual(result, [{ name: "@vercel/otel", version: "latest" }]);
+  });
+
   it("should return an array of changes for multiple packages", () => {
     const args = ["install", "express@4.17.1", "lodash@4.17.21"];
 

src/packagemanager/npx/parsing/parsePackagesFromArguments.js

@@ -81,7 +81,9 @@ function parsePackagename(arg, defaultTag) {
   const lastAtIndex = arg.lastIndexOf("@");
 
   let name, version;
-  if (lastAtIndex !== -1) {
+  // The index of the last "@" should be greater than 0
+  // If the index is 0, it means the package name starts with "@" (eg: "@vercel/otel")
+  if (lastAtIndex > 0) {
     name = arg.slice(0, lastAtIndex);
     version = arg.slice(lastAtIndex + 1);
   } else {

src/packagemanager/npx/parsing/parsePackagesFromArguments.spec.js

@@ -19,6 +19,14 @@ describe("parsePackagesFromArguments", () => {
     assert.deepEqual(result, [{ name: "http-server", version: "14.1.1" }]);
   });
 
+  it("should return the package in the format @vercel/otel", () => {
+    const args = ["@vercel/otel"];
+
+    const result = parsePackagesFromArguments(args);
+
+    assert.deepEqual(result, [{ name: "@vercel/otel", version: "latest" }]);
+  });
+
   it("should return the package with latest tag if absent", () => {
     const args = ["http-server"];
 

src/packagemanager/pnpm/parsing/parsePackagesFromArguments.spec.js

@@ -27,6 +27,14 @@ describe("standardPnpmArgumentParser", () => {
     assert.deepEqual(result, [{ name: "axios", version: "latest" }]);
   });
 
+  it("should return the package in the format @vercel/otel", () => {
+    const args = ["@vercel/otel"];
+
+    const result = parsePackagesFromArguments(args);
+
+    assert.deepEqual(result, [{ name: "@vercel/otel", version: "latest" }]);
+  });
+
   it("should return the package with latest tag if the version is absent and package starts with @", () => {
     const args = ["@aikidosec/package-name"];
 

src/packagemanager/yarn/parsing/parsePackagesFromArguments.js

@@ -77,7 +77,9 @@ function parsePackagename(arg, defaultTag) {
   const lastAtIndex = arg.lastIndexOf("@");
 
   let name, version;
-  if (lastAtIndex !== -1) {
+  // The index of the last "@" should be greater than 0
+  // If the index is 0, it means the package name starts with "@" (eg: "@vercel/otel")
+  if (lastAtIndex > 0) {
     name = arg.slice(0, lastAtIndex);
     version = arg.slice(lastAtIndex + 1);
   } else {

src/packagemanager/yarn/parsing/parsePackagesFromArguments.spec.js

@@ -38,6 +38,14 @@ describe("standardYarnArgumentParser", () => {
     ]);
   });
 
+  it("should return the package in the format @vercel/otel", () => {
+    const args = ["add", "@vercel/otel"];
+
+    const result = parsePackagesFromArguments(args);
+
+    assert.deepEqual(result, [{ name: "@vercel/otel", version: "latest" }]);
+  });
+
   it("should ignore options with parameters and return an array of changes", () => {
     const args = ["add", "--proxy", "http://localhost", "axios@1.9.0"];