milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 12:10:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make sure wrappers are removed from shell configs when running setup-ci after setup

Browse source
This commit is contained in:
Reinier Criel 2026-04-07 14:48:20 -07:00
parent 2c568bb2a2
commit f54c9233e1
3 changed files with 69 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

40
test/e2e/setup-ci.e2e.spec.js
View file

@ -53,6 +53,46 @@ describe("E2E: safe-chain setup-ci command", () => {
});
}
for (let shell of ["bash", "zsh"]) {
it(`safe-chain setup-ci removes legacy shell init left by a previous setup for ${shell}`, async () => {
const rcFile = shell === "zsh" ? "~/.zshrc" : "~/.bashrc";
// Simulate a previous non-CI install
const installationShell = await container.openShell(shell);
await installationShell.runCommand("safe-chain setup");
// Verify the legacy init line was added
const afterSetup = await installationShell.runCommand(`grep -c "init-posix.sh" ${rcFile} || true`);
assert.ok(
afterSetup.output.includes("1"),
`Expected init-posix.sh to be present in ${rcFile} after setup`
);
// Now run the CI install — should clean up the legacy line
await installationShell.runCommand("safe-chain setup-ci");
await installationShell.runCommand(
`echo 'export PATH="$HOME/.safe-chain/shims:$PATH"' >> ${rcFile}`
);
const afterSetupCi = await installationShell.runCommand(`grep -c "init-posix.sh" ${rcFile} || true`);
assert.ok(
!afterSetupCi.output.includes("1"),
`Expected init-posix.sh to be removed from ${rcFile} after setup-ci, but it was still present`
);
// Verify npm still works through shims in a new shell
const projectShell = await container.openShell(shell);
const result = await projectShell.runCommand(
"npm i axios@1.13.0 --safe-chain-logging=verbose"
);
assert.ok(
result.output.includes("Safe-chain: Scanned"),
`Expected npm to be wrapped by safe-chain shim after setup-ci.\nOutput was:\n${result.output}`
);
});
}
it("writes to GITHUB_PATH when GITHUB_PATH is set", async () => {
const installationShell = await container.openShell("zsh");
await installationShell.runCommand("export GITHUB_PATH=/tmp/github_path");