remove trailing slashes and fix test failures

packages/safe-chain/src/config/settings.js

@@ -207,21 +207,34 @@ export function getMalwareListBaseUrl() {
   // Priority 1: CLI argument
   const cliValue = cliArguments.getMalwareListBaseUrl();
   if (cliValue) {
-    return cliValue;
+    return removeTrailingSlashes(cliValue);
   }
 
   // Priority 2: Environment variable
   const envValue = environmentVariables.getMalwareListBaseUrl();
   if (envValue) {
-    return envValue;
+    return removeTrailingSlashes(envValue);
   }
 
   // Priority 3: Config file
   const configValue = configFile.getMalwareListBaseUrl();
   if (configValue) {
-    return configValue;
+    return removeTrailingSlashes(configValue);
   }
 
   // Default
-  return "https://malware-list.aikido.dev";
+  return removeTrailingSlashes("https://malware-list.aikido.dev");
+}
+
+/**
+ * Removes trailing slashes from a URL-like string.
+ * @param {string} value
+ * @returns {string}
+ */
+function removeTrailingSlashes(value) {
+  if (!value || typeof value !== "string") {
+    return value;
+  }
+
+  return value.replace(/\/+$/, "");
 }

packages/safe-chain/src/config/settings.spec.js

@@ -562,6 +562,32 @@ describe("getMalwareListBaseUrl", () => {
     assert.strictEqual(url, "https://malware-list.aikido.dev");
   });
 
+  it("should trim trailing slash from CLI argument", () => {
+    initializeCliArguments(["--safe-chain-malware-list-base-url=https://cli-mirror.com/"]);
+
+    const url = getMalwareListBaseUrl();
+
+    assert.strictEqual(url, "https://cli-mirror.com");
+  });
+
+  it("should trim trailing slash from environment variable", () => {
+    process.env[envVarName] = "https://env-mirror.com/";
+
+    const url = getMalwareListBaseUrl();
+
+    assert.strictEqual(url, "https://env-mirror.com");
+  });
+
+  it("should trim trailing slash from config file value", () => {
+    configFileContent = JSON.stringify({
+      malwareListBaseUrl: "https://config-mirror.com/",
+    });
+
+    const url = getMalwareListBaseUrl();
+
+    assert.strictEqual(url, "https://config-mirror.com");
+  });
+
   it("should return CLI argument value with highest priority", () => {
     initializeCliArguments(["--safe-chain-malware-list-base-url=https://cli-mirror.com"]);