milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 20:20:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Handle code quality comments

Browse source
This commit is contained in:
Sander Declerck 2026-01-19 15:22:24 +01:00
parent fa94784130
commit d86246a71d
No known key found for this signature in database
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/safe-chain/bin/safe-chain.js
View file

@ -64,7 +64,9 @@ if (tool) {
} else if (command === "setup") { } else if (command === "setup") {
setup(); setup();
} else if (command === "--ultimate") { } else if (command === "--ultimate") {
installUltimate(); (async () => {
await installUltimate();
})();
} else if (command === "teardown") { } else if (command === "teardown") {
teardownDirectories(); teardownDirectories();
teardown(); teardown();

4
packages/safe-chain/src/installation/installOnWindows.js
View file

@ -103,7 +103,7 @@ function runMsiInstaller(msiPath) {
// /i = install // /i = install
// /qn = quiet mode (no UI) // /qn = quiet mode (no UI)
ui.writeVerbose(`Running: msiexec /i "${msiPath}" /qn`); ui.writeVerbose(`Running: msiexec /i "${msiPath}" /qn`);
execSync(`msiexec /i "${msiPath}" /qn`, { stdio: "inherit" }); execSync(`msiexec /i "${msiPath}" /qn`, { stdio: "inherit" }); // noopengrep this is ok, we control the msiPath
} }
function stopServiceIfRunning() { function stopServiceIfRunning() {
@ -128,7 +128,7 @@ function startService() {
return; return;
} }
} catch { } catch {
// Service might not exist yet or query failed, proceed with start ui.writeVerbose("Service not found or query failed, attempting to start.");
} }
ui.writeVerbose('Running: net start "SafeChainAgent"'); ui.writeVerbose('Running: net start "SafeChainAgent"');

4
packages/safe-chain/src/installation/installUltimate.js
View file

@ -3,13 +3,13 @@ import { ui } from "../environment/userInteraction.js";
import { initializeCliArguments } from "../config/cliArguments.js"; import { initializeCliArguments } from "../config/cliArguments.js";
import { installOnWindows } from "./installOnWindows.js"; import { installOnWindows } from "./installOnWindows.js";
export function installUltimate() { export async function installUltimate() {
initializeCliArguments(process.argv); initializeCliArguments(process.argv);
const operatingSystem = platform(); const operatingSystem = platform();
if (operatingSystem === "win32") { if (operatingSystem === "win32") {
installOnWindows(); await installOnWindows();
} else { } else {
ui.writeInformation( ui.writeInformation(
`${operatingSystem} is not supported yet by safe-chain's ultimate version.`, `${operatingSystem} is not supported yet by safe-chain's ultimate version.`,