Improve types and remove async

packages/safe-chain/src/packagemanager/bun/createBunPackageManager.js

@@ -12,7 +12,7 @@ export function createBunPackageManager() {
     // For bun, we use the proxy-only approach to block package downloads,
     // so we don't need to analyze commands.
     isSupportedCommand: () => false,
-    getDependencyUpdatesForCommand: async () => [],
+    getDependencyUpdatesForCommand: () => [],
   };
 }
 
@@ -26,7 +26,7 @@ export function createBunxPackageManager() {
     // For bunx, we use the proxy-only approach to block package downloads,
     // so we don't need to analyze commands.
     isSupportedCommand: () => false,
-    getDependencyUpdatesForCommand: async () => [],
+    getDependencyUpdatesForCommand: () => [],
   };
 }
 

packages/safe-chain/src/packagemanager/currentPackageManager.js

@@ -17,11 +17,18 @@ const state = {
   packageManagerName: null,
 };
 
+/**
+ * @typedef {Object} GetDependencyUpdatesResult
+ * @property {string} name
+ * @property {string} version
+ * @property {string} type
+ */
+
 /**
  * @typedef {Object} PackageManager
  * @property {(args: string[]) => Promise<{ status: number }>} runCommand
  * @property {(args: string[]) => boolean} isSupportedCommand
- * @property {(args: string[]) => Promise<{name: string, version: string, type: string}[]>} getDependencyUpdatesForCommand
+ * @property {(args: string[]) => Promise<GetDependencyUpdatesResult[]> | GetDependencyUpdatesResult[]} getDependencyUpdatesForCommand
  */
 
 /**

packages/safe-chain/src/packagemanager/npm/createPackageManager.js

@@ -28,7 +28,7 @@ export function createNpmPackageManager() {
   /**
    * @param {string[]} args
    *
-   * @returns {Promise<{name: string, version: string, type: string}[]>}
+   * @returns {ReturnType<import("../currentPackageManager.js").PackageManager["getDependencyUpdatesForCommand"]>}
    */
   function getDependencyUpdatesForCommand(args) {
     const scanner = findDependencyScannerForCommand(

packages/safe-chain/src/packagemanager/npm/dependencyScanner/commandArgumentScanner.js

@@ -16,7 +16,7 @@ import { hasDryRunArg } from "../utils/npmCommands.js";
 
 /**
  * @typedef {Object} CommandArgumentScanner
- * @property {(args: string[]) => Promise<ScanResult[]>} scan
+ * @property {(args: string[]) => Promise<ScanResult[]> | ScanResult[]} scan
  * @property {(args: string[]) => boolean} shouldScan
  */
 

packages/safe-chain/src/packagemanager/npm/dependencyScanner/nullScanner.js

@@ -3,7 +3,7 @@
  */
 export function nullScanner() {
   return {
-    scan: async () => [],
+    scan: () => [],
     shouldScan: () => false,
   };
 }

packages/safe-chain/src/packagemanager/pnpm/createPackageManager.js

@@ -41,7 +41,7 @@ export function createPnpxPackageManager() {
 /**
  * @param {string[]} args
  * @param {boolean} isPnpx
- * @returns {Promise<import("../npm/dependencyScanner/commandArgumentScanner.js").ScanResult[]>}
+ * @returns {ReturnType<import("../currentPackageManager.js").PackageManager["getDependencyUpdatesForCommand"]>}
  */
 function getDependencyUpdatesForCommand(args, isPnpx) {
   if (isPnpx) {