milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 12:10:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

PR comment: extract requireRootPrivileges / requireAdminPrivileges into separate function

Browse source
This commit is contained in:
Sander Declerck 2026-01-28 07:53:39 +01:00
parent 7218d778cf
commit a3ab80b8b4
No known key found for this signature in database
2 changed files with 41 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

34
packages/safe-chain/src/installation/installOnMacOS.js
View file

@ -9,11 +9,29 @@ import chalk from "chalk";
const MACOS_PKG_IDENTIFIER = "com.aikidosecurity.safechainultimate";
export async function installOnMacOS() {
if (!isRunningAsRoot()) {
/**
* Checks if root privileges are available and displays error message if not.
* @param {string} command - The sudo command to show in the error message
* @returns {boolean} True if running as root, false otherwise.
*/
function requireRootPrivileges(command) {
if (isRunningAsRoot()) {
return true;
}
ui.writeError("Root privileges required.");
ui.writeInformation("Please run this command with sudo:");
ui.writeInformation(" sudo safe-chain ultimate");
ui.writeInformation(` ${command}`);
return false;
}
function isRunningAsRoot() {
const rootUserUid = 0;
return process.getuid?.() === rootUserUid;
}
export async function installOnMacOS() {
if (!requireRootPrivileges("sudo safe-chain ultimate")) {
return;
}
@ -56,10 +74,7 @@ export async function installOnMacOS() {
}
export async function uninstallOnMacOS() {
if (!isRunningAsRoot()) {
ui.writeError("Root privileges required.");
ui.writeInformation("Please run this command with sudo:");
ui.writeInformation(" sudo safe-chain ultimate uninstall");
if (!requireRootPrivileges("sudo safe-chain ultimate uninstall")) {
return;
}
@ -136,11 +151,6 @@ function forgetPackage() {
}
}
function isRunningAsRoot() {
const rootUserUid = 0;
return process.getuid?.() === rootUserUid;
}
/**
* @param {string} pkgPath
*/

28
packages/safe-chain/src/installation/installOnWindows.js
View file

@ -10,11 +10,7 @@ const WINDOWS_SERVICE_NAME = "SafeChainUltimate";
const WINDOWS_APP_NAME = "SafeChain Ultimate";
export async function uninstallOnWindows() {
if (!(await isRunningAsAdmin())) {
ui.writeError("Administrator privileges required.");
ui.writeInformation(
"Please run this command in an elevated terminal (Run as Administrator).",
);
if (!(await requireAdminPrivileges())) {
return;
}
@ -37,11 +33,7 @@ export async function uninstallOnWindows() {
}
export async function installOnWindows() {
if (!(await isRunningAsAdmin())) {
ui.writeError("Administrator privileges required.");
ui.writeInformation(
"Please run this command in an elevated terminal (Run as Administrator).",
);
if (!(await requireAdminPrivileges())) {
return;
}
@ -76,6 +68,22 @@ export async function installOnWindows() {
}
}
/**
* Checks if admin privileges are available and displays error message if not.
* @returns {Promise<boolean>} True if running as admin, false otherwise.
*/
async function requireAdminPrivileges() {
if (await isRunningAsAdmin()) {
return true;
}
ui.writeError("Administrator privileges required.");
ui.writeInformation(
"Please run this command in an elevated terminal (Run as Administrator).",
);
return false;
}
async function isRunningAsAdmin() {
// Uses Windows Security API to check if current process has admin privileges.
// Returns "True" or "False" as a string.