From 36213a52f1db343d55dea6083103643fcf7c5d3d Mon Sep 17 00:00:00 2001 From: Hans Ott Date: Thu, 9 Oct 2025 16:52:05 +0200 Subject: [PATCH 1/4] Run unit tests on windows --- .github/workflows/test-on-pr.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-on-pr.yml b/.github/workflows/test-on-pr.yml index 5661f97..bc6e5a2 100644 --- a/.github/workflows/test-on-pr.yml +++ b/.github/workflows/test-on-pr.yml @@ -6,7 +6,12 @@ jobs: unit-test: name: Run unit tests and linting - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + + strategy: + fail-fast: false + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code From 46cbb4fd281f835856dcfc7b09dc32cb32cbe952 Mon Sep 17 00:00:00 2001 From: Sander Declerck Date: Fri, 5 Dec 2025 18:06:16 +0100 Subject: [PATCH 2/4] Ignore scripts when running npm ci on Windows --- .github/workflows/test-on-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-on-pr.yml b/.github/workflows/test-on-pr.yml index 7b7f061..06dde4c 100644 --- a/.github/workflows/test-on-pr.yml +++ b/.github/workflows/test-on-pr.yml @@ -28,7 +28,7 @@ jobs: safe-chain setup-ci - name: Install dependencies - run: npm ci + run: npm ci --ignore-scripts - name: Run unit tests run: npm test From dfed1299c4bcb9aac29537211dcea3066f092534 Mon Sep 17 00:00:00 2001 From: Sander Declerck Date: Fri, 5 Dec 2025 18:09:22 +0100 Subject: [PATCH 3/4] Overwrite artifact --- .github/workflows/test-on-pr.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-on-pr.yml b/.github/workflows/test-on-pr.yml index 06dde4c..e7cffd3 100644 --- a/.github/workflows/test-on-pr.yml +++ b/.github/workflows/test-on-pr.yml @@ -47,6 +47,7 @@ jobs: with: name: safe-chain-package path: aikidosec-safe-chain-*.tgz + overwrite: true e2e-tests: name: Run E2E tests From 19399b491b837a159b14554e566a7268ba0eb96f Mon Sep 17 00:00:00 2001 From: Sander Declerck Date: Fri, 5 Dec 2025 18:10:41 +0100 Subject: [PATCH 4/4] Only upload artifact on linux --- .github/workflows/test-on-pr.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-on-pr.yml b/.github/workflows/test-on-pr.yml index e7cffd3..f754931 100644 --- a/.github/workflows/test-on-pr.yml +++ b/.github/workflows/test-on-pr.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest, windows-latest, macos-latest] steps: - name: Checkout code @@ -40,14 +40,15 @@ jobs: run: npm run typecheck --workspace=packages/safe-chain - name: Create package tarball + if: matrix.os == 'ubuntu-latest' run: npm pack --workspace=packages/safe-chain - name: Upload package tarball uses: actions/upload-artifact@v4 + if: matrix.os == 'ubuntu-latest' with: name: safe-chain-package path: aikidosec-safe-chain-*.tgz - overwrite: true e2e-tests: name: Run E2E tests