milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 12:10:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #201 from AikidoSec/mitm-improved-logging

Browse source 
Improve logs for MITM handler
This commit is contained in:
bitterpanda 2025-12-03 13:36:36 +01:00 • committed by GitHub
commit 9518be35b4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/safe-chain/src/registryProxy/mitmRequestHandler.js
View file

@ -117,14 +117,16 @@ function forwardRequest(req, hostname, res, requestHandler) {
proxyReq.on("error", (err) => { proxyReq.on("error", (err) => {
ui.writeVerbose( ui.writeVerbose(
`Safe-chain: Error occurred while proxying request: ${err.message}` `Safe-chain: Error occurred while proxying request to ${req.url} for ${hostname}: ${err.message}`
); );
res.writeHead(502); res.writeHead(502);
res.end("Bad Gateway"); res.end("Bad Gateway");
}); });
req.on("error", (err) => { req.on("error", (err) => {
ui.writeError(`Safe-chain: Error reading client request: ${err.message}`); ui.writeError(
`Safe-chain: Error reading client request to ${req.url} for ${hostname}: ${err.message}`
);
proxyReq.destroy(); proxyReq.destroy();
}); });
@ -175,7 +177,7 @@ function createProxyRequest(hostname, req, res, requestHandler) {
const proxyReq = https.request(options, (proxyRes) => { const proxyReq = https.request(options, (proxyRes) => {
proxyRes.on("error", (err) => { proxyRes.on("error", (err) => {
ui.writeError( ui.writeError(
`Safe-chain: Error reading upstream response: ${err.message}` `Safe-chain: Error reading upstream response to ${req.url} for ${hostname}: ${err.message}`
); );
if (!res.headersSent) { if (!res.headersSent) {
res.writeHead(502); res.writeHead(502);
@ -184,7 +186,9 @@ function createProxyRequest(hostname, req, res, requestHandler) {
}); });
if (!proxyRes.statusCode) { if (!proxyRes.statusCode) {
ui.writeError("Safe-chain: Proxy response missing status code"); ui.writeError(
`Safe-chain: Proxy response missing status code to ${req.url} for ${hostname}`
);
res.writeHead(500); res.writeHead(500);
res.end("Internal Server Error"); res.end("Internal Server Error");
return; return;