milliways-infosec/AikidoSec-safe-chain
7
0
Fork 0
mirror of https://github.com/AikidoSec/safe-chain.git synced 2026-05-26 20:20:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #95 from AikidoSec/proxy-socket-check-if-writable

Browse source 
Check if a socket is writable before writing to it
This commit is contained in:
Sander Declerck 2025-10-08 19:51:57 +02:00 • committed by GitHub
commit 662b26a2d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/test-on-pr.yml vendored
View file

@ -101,7 +101,7 @@ jobs:
- name: Setup safe-chain
run: |
npm i -g @aikidosec/safe-chain
npm i -g @aikidosec/safe-chain@1.0.24
safe-chain setup-ci
- name: Install dependencies (root)

20
packages/safe-chain/src/registryProxy/tunnelRequestHandler.js
View file

@ -35,7 +35,9 @@ function tunnelRequestToDestination(req, clientSocket, head) {
ui.writeError(
`Safe-chain: error connecting to ${hostname}:${port} - ${err.message}`
);
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
if (clientSocket.writable) {
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
}
});
}
@ -76,8 +78,12 @@ function tunnelRequestViaProxy(req, clientSocket, head, proxyUrl) {
ui.writeError(
`Safe-chain: proxy CONNECT failed: ${response.split("\r\n")[0]}`
);
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
proxySocket.end();
if (clientSocket.writable) {
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
}
if (proxySocket.writable) {
proxySocket.end();
}
}
});
@ -88,11 +94,15 @@ function tunnelRequestViaProxy(req, clientSocket, head, proxyUrl) {
proxy.port || 8080
} - ${err.message}`
);
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
if (clientSocket.writable) {
clientSocket.end("HTTP/1.1 502 Bad Gateway\r\n\r\n");
}
}
});
clientSocket.on("error", () => {
proxySocket.end();
if (proxySocket.writable) {
proxySocket.end();
}
});
}