Update main.js code flow so proxy always gets stopped + add comment on why exit status is handled in bin/aikido-(tool).js

packages/safe-chain/src/main.js

@@ -16,16 +16,17 @@ export async function main(args) {
     args = initializeCliArguments(args);
 
     if (shouldScanCommand(args)) {
-      await scanCommand(args);
+      const resultCode = await scanCommand(args);
+
+      // Returning the exit code back to the caller allows the promise
+      //  to be awaited in the bin files and return the correct exit code
+      if (resultCode !== 0) {
+        return resultCode;
       }
-  } catch (error) {
-    ui.writeError("Failed to check for malicious packages:", error.message);
-    process.exit(1);
     }
 
     var result = await getPackageManager().runCommand(args);
 
-  await proxy.stopServer();
     proxy.verifyNoMaliciousPackages();
 
     ui.emptyLine();
@@ -35,5 +36,16 @@ export async function main(args) {
       )} Safe-chain: Command completed, no malicious packages found.`
     );
 
+    // Returning the exit code back to the caller allows the promise
+    //  to be awaited in the bin files and return the correct exit code
     return result.status;
+  } catch (error) {
+    ui.writeError("Failed to check for malicious packages:", error.message);
+
+    // Returning the exit code back to the caller allows the promise
+    //  to be awaited in the bin files and return the correct exit code
+    return 1;
+  } finally {
+    await proxy.stopServer();
+  }
 }

packages/safe-chain/src/scanning/index.js

@@ -62,9 +62,11 @@ export async function scanCommand(args) {
 
   if (!audit || audit.isAllowed) {
     spinner.stop();
+    return 0;
   } else {
     printMaliciousChanges(audit.disallowedChanges, spinner);
     await onMalwareFound();
+    return 1;
   }
 }