From 3ea4e82acb6b058f2c504298027e55616573fccc Mon Sep 17 00:00:00 2001
From: Sander Declerck <sander@sdsoftware.be>
Date: Tue, 4 Nov 2025 11:26:07 +0100
Subject: [PATCH] Write a warning if no version was returned from the malware
 download, causing the malware db not to be cached.

---
 packages/safe-chain/src/scanning/malwareDatabase.js | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/safe-chain/src/scanning/malwareDatabase.js b/packages/safe-chain/src/scanning/malwareDatabase.js
index 03c7081..539044b 100644
--- a/packages/safe-chain/src/scanning/malwareDatabase.js
+++ b/packages/safe-chain/src/scanning/malwareDatabase.js
@@ -75,9 +75,15 @@ async function getMalwareDatabase() {
     if (version) {
       // Only cache the malware database when we have a version.
       writeDatabaseToLocalCache(malwareDatabase, version);
+      return malwareDatabase;
+    } else {
+      // We received a valid malware database, but the response
+      // did not contain an etag header with the version
+      ui.writeWarning(
+        "The malware database was downloaded, but could not be cached due to a missing version."
+      );
+      return malwareDatabase;
     }
-
-    return malwareDatabase;
   } catch (/** @type any */ error) {
     if (cachedDatabase) {
       ui.writeWarning(