From 0afea0eed6ef559b994810eb0a81dfde54e7badb Mon Sep 17 00:00:00 2001 From: Hans Ott Date: Thu, 9 Oct 2025 16:44:55 +0200 Subject: [PATCH] Remove `safeSpawnSync` (unused) --- packages/safe-chain/src/utils/safeSpawn.js | 5 ----- packages/safe-chain/src/utils/safeSpawn.spec.js | 13 ++++--------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/packages/safe-chain/src/utils/safeSpawn.js b/packages/safe-chain/src/utils/safeSpawn.js index c5cd913..b8c9274 100644 --- a/packages/safe-chain/src/utils/safeSpawn.js +++ b/packages/safe-chain/src/utils/safeSpawn.js @@ -13,11 +13,6 @@ function buildCommand(command, args) { return `${command} ${escapedArgs.join(" ")}`; } -export function safeSpawnSync(command, args, options = {}) { - const fullCommand = buildCommand(command, args); - return spawnSync(fullCommand, { ...options, shell: true }); -} - export async function safeSpawn(command, args, options = {}) { const fullCommand = buildCommand(command, args); return new Promise((resolve, reject) => { diff --git a/packages/safe-chain/src/utils/safeSpawn.spec.js b/packages/safe-chain/src/utils/safeSpawn.spec.js index d325f8a..1ffdc25 100644 --- a/packages/safe-chain/src/utils/safeSpawn.spec.js +++ b/packages/safe-chain/src/utils/safeSpawn.spec.js @@ -2,7 +2,7 @@ import { describe, it, beforeEach, afterEach, mock } from "node:test"; import assert from "node:assert"; describe("safeSpawn", () => { - let safeSpawnSync, safeSpawn; + let safeSpawn; let spawnCalls = []; beforeEach(async () => { @@ -35,7 +35,6 @@ describe("safeSpawn", () => { // Import after mocking const safeSpawnModule = await import("./safeSpawn.js"); - safeSpawnSync = safeSpawnModule.safeSpawnSync; safeSpawn = safeSpawnModule.safeSpawn; }); @@ -45,14 +44,10 @@ describe("safeSpawn", () => { // Helper to run either sync or async variant async function runSafeSpawn(variant, command, args, options) { - if (variant === "sync") { - return safeSpawnSync(command, args, options); - } else { - return await safeSpawn(command, args, options); - } + return await safeSpawn(command, args, options); } - for (let variant of ["sync", "async"]) { + for (let variant of ["async"]) { it(`should pass basic command and arguments correctly (${variant})`, async () => { await runSafeSpawn(variant, "echo", ["hello"]); @@ -106,4 +101,4 @@ describe("safeSpawn", () => { assert.strictEqual(spawnCalls[0].options.shell, true); }); } -}); \ No newline at end of file +});